Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ledger sing message support #1

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

feat: Ledger sing message support #1

wants to merge 29 commits into from

Conversation

JordiParraCrespo
Copy link

@JordiParraCrespo JordiParraCrespo commented Dec 10, 2024 •
edited
Loading

Ledger sing message support

This PR adds support for message signing using Ledger hardware wallet.

Key Changes:

  • Added signMessage and signDelegateAction methods to the ledger-client.
  • Optimized CHUNK_SIZE to reduce the number of communication calls to the Ledger device.
  • Integrated signMessage into the ledger class.
  • Added unit tests to cover the new message signing functionality.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

AgustinMJ
AgustinMJ approved these changes Dec 10, 2024
View reviewed changes
Copy link

@AgustinMJ AgustinMJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!!🐐

packages/ledger/src/lib/ledger-client.spec.ts Show resolved Hide resolved
packages/ledger/src/lib/ledger.spec.ts Show resolved Hide resolved
packages/ledger/src/lib/ledger.ts Show resolved Hide resolved
gtsonevv and others added 6 commits December 13, 2024 15:23
@gtsonevv
Merge pull request near#1229 from kujtimprenku/fix/mintbase-js-and-naj
6611c19 
fix: Remove @near-js/ aliases from tsconfig.base.json
@gtsonevv
Merge pull request near#1230 from kujtimprenku/fix/remove-near-js-ind…
5deac85 
…ividual-packages

fix: Fix imports and remove unnecessary peer dependency
@gtsonevv
Merge pull request near#1231 from kujtimprenku/feat/bump-borsh-depend…
37616ba 
…ency

feat: Bump borsh to v1.0.0 and remove the better-sqlite3
@gtsonevv
chore-bump-version-v8.9.15
8174d32
@gtsonevv
Merge pull request near#1268 from near/chore-bump-version-v8.9.15
b67dbba 
chore-bump-version-v8.9.15
@gtsonevv
Merge pull request near#1269 from near/dev
f7ca952 
v8.9.15 Release (dev → main)
@socket-security Socket Security
Copy link

socket-security bot commented Dec 19, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@semantic-release/[email protected] filesystem, network 0 67.1 kB semantic-release-bot

View full report↗︎

Elabar and others added 7 commits January 2, 2025 14:38
@Elabar
chore: code linting
3a83dd0
@denbite
Merge pull request near#1272 from near/update_peer_dependencies
93ae2de 
fix: define range of `near-api-js` versions as peerDependency instead of an exact one
@Elabar
feat: use nonce instead of incremental promise id
86655df 
- also added a ping in signIn that should resolve almost immediately to avoid auto login stuck
@Elabar
feat: allow post message for all sites, add a source tag in message
5cfc978 
- this is so our app make sure we are processing the right message
@Elabar
feat: pass window location href
2429bd6
@trechriron
Merge pull request near#1275 from Elabar/meteor-wallet-mobile-app
69ab20d 
feat: add support for meteor wallet mobile app
@JordiParraCrespo
Merge branch 'dev' of github.com:near/wallet-selector into ledger/fea…
41030ba 
…t/sign-message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgustinMJ AgustinMJ AgustinMJ approved these changes

@AdriaCarrera AdriaCarrera Awaiting requested review from AdriaCarrera

@obnol obnol Awaiting requested review from obnol

@GuillemGarciaDev GuillemGarciaDev Awaiting requested review from GuillemGarciaDev

@vriveraPeersyst vriveraPeersyst Awaiting requested review from vriveraPeersyst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JordiParraCrespo @AgustinMJ @gtsonevv @kujtimprenku @thisisjoshford @denbite @Elabar @trechriron